Nodejs/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-11-21 10:59:27 +00:00
Code Issues Actions 25 Packages Projects Releases Wiki Activity

test: remove unneeded bind() and related comments

Browse Source 
As mentioned in the comment of the changed file, "a libuv limitation
makes it necessary to bind()". But, that is not the case in this test.
The subsequent call to send() results in an implicit bind().

PR-URL: https://github.com/nodejs/node/pull/5023
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
This commit is contained in:
Aayush Naik 2016-02-01 16:04:14 +05:30 committed by Rich Trott
parent 98b721ed26
commit 93bacfd00f
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/internet/test-dgram-multicast-multi-process.js
View File

@ -132,10 +132,6 @@ if (process.argv[2] !== 'child') {
}
var sendSocket = dgram.createSocket('udp4');
// FIXME: a libuv limitation makes it necessary to bind()
// before calling any of the set*() functions. The bind()
// call is what creates the actual socket.
sendSocket.bind();
// The socket is actually created async now.
sendSocket.on('listening', function() {