Nodejs/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-11-21 10:59:27 +00:00
Code Issues Actions 25 Packages Projects Releases Wiki Activity

tools,doc: use V8::DisposePlatform

Browse Source 
V8::ShutdownPlatform has been deprecated and does the same.

PR-URL: https://github.com/nodejs/node/pull/41610
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Michaël Zasso 2022-01-20 11:12:51 +01:00
parent 30c4e1d952
commit 86b77f7d0f
No known key found for this signature in database
GPG Key ID: 770F7A9A5AE15600
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
doc/api/embedding.md
View File

@ -61,7 +61,7 @@ int main(int argc, char** argv) {
int ret = RunNodeInstance(platform.get(), args, exec_args); int ret = RunNodeInstance(platform.get(), args, exec_args);
V8::Dispose(); V8::Dispose();
V8::ShutdownPlatform(); V8::DisposePlatform();
return ret; return ret;
} }
``` ```

2
test/cctest/node_test_fixture.h
View File

@ -98,7 +98,7 @@ class NodeZeroIsolateTestFixture : public ::testing::Test {
while (uv_loop_alive(&current_loop)) { while (uv_loop_alive(&current_loop)) {
uv_run(&current_loop, UV_RUN_ONCE); uv_run(&current_loop, UV_RUN_ONCE);
} }
v8::V8::ShutdownPlatform(); v8::V8::DisposePlatform();
CHECK_EQ(0, uv_loop_close(&current_loop)); CHECK_EQ(0, uv_loop_close(&current_loop));
} }

2
test/embedding/embedtest.cc
View File

@ -40,7 +40,7 @@ int main(int argc, char** argv) {
int ret = RunNodeInstance(platform.get(), args, exec_args); int ret = RunNodeInstance(platform.get(), args, exec_args);
V8::Dispose(); V8::Dispose();
V8::ShutdownPlatform(); V8::DisposePlatform();
return ret; return ret;
} }

2
tools/code_cache/mkcodecache.cc
View File

@ -68,6 +68,6 @@ int main(int argc, char* argv[]) {
} }
isolate->Dispose(); isolate->Dispose();
v8::V8::ShutdownPlatform(); v8::V8::DisposePlatform();
return 0; return 0;
} }