Nodejs/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-11-21 10:59:27 +00:00
Code Issues Actions 25 Packages Projects Releases Wiki Activity

build: remove .git folders when testing V8

Browse Source 
When running `make test-v8` V8's `gclient sync` converts folders
under `deps/v8/third_party` into git repositories. Unfortunately
the files that were checked in under `deps/v8/third_party/zlib`
have been modified from the upstream Chromium repository (some
files have been deleted and there are whitespace differences in
some of the files that were kept) so whenever the Node.js source
tree is hard reset/checked out `gclient sync` notices there are
unstaged changes as the files in the Node.js source tree do not
match those of the upstream Chromium third party zlib commit.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: https://github.com/nodejs/node/pull/32877
Refs: https://github.com/nodejs/build/issues/2256
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit is contained in:
Richard Lau 2020-04-16 05:35:01 -04:00 committed by Matheus Marchini
parent d3d5eca657
commit 6d77df840c
No known key found for this signature in database
GPG Key ID: BE516BA4874DB4D9
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tools/make-v8.sh
View File

@ -4,6 +4,7 @@ BUILD_ARCH_TYPE=$1
V8_BUILD_OPTIONS=$2
cd deps/v8
find . -type d -name .git | xargs rm -rf
tools/node/fetch_deps.py .
ARCH="`arch`"