From 6ce718df60dc4bf2a2fd1d8395e7d3b34ab6511a Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Wed, 17 Jan 2024 17:56:46 +0000 Subject: [PATCH] tools: limit parallelism with ninja in V8 builds MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If `JOBS` has been set in the environment to limit build parallelism, pass that onto `ninja` when building V8. PR-URL: https://github.com/nodejs/node/pull/51473 Reviewed-By: Yagiz Nizipli Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca Reviewed-By: Michael Dawson --- tools/make-v8.sh | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tools/make-v8.sh b/tools/make-v8.sh index 62cabc70a6e..f51623be9ea 100755 --- a/tools/make-v8.sh +++ b/tools/make-v8.sh @@ -9,6 +9,11 @@ cd deps/v8 || exit find . -type d -name .git -print0 | xargs -0 rm -rf ../../tools/v8/fetch_deps.py . +JOBS_ARG= +if [ "${JOBS}" ]; then + JOBS_ARG="-j ${JOBS}" +fi + ARCH=$(arch) if [ "$ARCH" = "s390x" ] || [ "$ARCH" = "ppc64le" ]; then TARGET_ARCH=$ARCH @@ -46,10 +51,10 @@ if [ "$ARCH" = "s390x" ] || [ "$ARCH" = "ppc64le" ]; then gcc --version export PKG_CONFIG_PATH=$BUILD_TOOLS/pkg-config gn gen -v "out.gn/$BUILD_ARCH_TYPE" --args="is_component_build=false is_debug=false use_goma=false goma_dir=\"None\" use_custom_libcxx=false v8_target_cpu=\"$TARGET_ARCH\" target_cpu=\"$TARGET_ARCH\" v8_enable_backtrace=true $CC_WRAPPER" - ninja -v -C "out.gn/$BUILD_ARCH_TYPE" d8 cctest inspector-test + ninja -v -C "out.gn/$BUILD_ARCH_TYPE" "${JOBS_ARG}" d8 cctest inspector-test else DEPOT_TOOLS_DIR="$(cd _depot_tools && pwd)" # shellcheck disable=SC2086 PATH="$DEPOT_TOOLS_DIR":$PATH tools/dev/v8gen.py "$BUILD_ARCH_TYPE" --no-goma $V8_BUILD_OPTIONS - PATH="$DEPOT_TOOLS_DIR":$PATH ninja -C "out.gn/$BUILD_ARCH_TYPE/" d8 cctest inspector-test + PATH="$DEPOT_TOOLS_DIR":$PATH ninja -C "out.gn/$BUILD_ARCH_TYPE/" "${JOBS_ARG}" d8 cctest inspector-test fi