Nodejs/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-11-21 10:59:27 +00:00
Code Issues Actions 25 Packages Projects Releases Wiki Activity

test: move debugger test case to parallel

Browse Source 
Move test case that does not require a predetermined port to parallel.

PR-URL: https://github.com/nodejs/node/pull/39300
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
This commit is contained in:
Rich Trott 2021-07-07 10:51:29 -07:00
parent debdc1dbb6
commit 6463adf183
2 changed files with 36 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
test/parallel/test-debugger-unavailable-port.js Normal file
View File

@ -0,0 +1,36 @@
'use strict';
const common = require('../common');
common.skipIfInspectorDisabled();
const fixtures = require('../common/fixtures');
const startCLI = require('../common/debugger');
const assert = require('assert');
const { createServer } = require('net');
// Launch w/ unavailable port.
(async () => {
const blocker = createServer((socket) => socket.end());
const port = await new Promise((resolve, reject) => {
blocker.on('error', reject);
blocker.listen(0, '127.0.0.1', () => resolve(blocker.address().port));
});
try {
const script = fixtures.path('debugger', 'three-lines.js');
const cli = startCLI([`--port=${port}`, script]);
const code = await cli.quit();
assert.doesNotMatch(
cli.output,
/report this bug/,
'Omits message about reporting this as a bug');
assert.ok(
cli.output.includes(`waiting for 127.0.0.1:${port} to be free`),
'Tells the user that the port wasn\'t available');
assert.strictEqual(code, 1);
} finally {
blocker.close();
}
})().then(common.mustCall());

28
test/sequential/test-debugger-invalid-args.js
View File

@ -3,11 +3,9 @@ const common = require('../common');
common.skipIfInspectorDisabled();
const fixtures = require('../common/fixtures');
const startCLI = require('../common/debugger');
const assert = require('assert');
const { createServer } = require('net');
// Launch CLI w/o args.
{
@ -31,29 +29,3 @@ const { createServer } = require('net');
assert.strictEqual(code, 1);
});
}
// Launch w/ unavailable port.
(async () => {
const blocker = createServer((socket) => socket.end());
const port = await new Promise((resolve, reject) => {
blocker.on('error', reject);
blocker.listen(0, '127.0.0.1', () => resolve(blocker.address().port));
});
try {
const script = fixtures.path('debugger', 'three-lines.js');
const cli = startCLI([`--port=${port}`, script]);
const code = await cli.quit();
assert.doesNotMatch(
cli.output,
/report this bug/,
'Omits message about reporting this as a bug');
assert.ok(
cli.output.includes(`waiting for 127.0.0.1:${port} to be free`),
'Tells the user that the port wasn\'t available');
assert.strictEqual(code, 1);
} finally {
blocker.close();
}
})().then(common.mustCall());