Nodejs/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-11-21 10:59:27 +00:00
Code Issues Actions 25 Packages Projects Releases Wiki Activity

Revert "net: validate host name for server listen"

Browse Source 
This reverts commit 52322aa42a.

PR-URL: https://github.com/nodejs/node/pull/54554
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This commit is contained in:
jakecastelli 2024-08-26 01:12:58 +09:30
parent 885692a34f
commit 4f14eb1545
2 changed files with 0 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/net.js
View File

@ -35,8 +35,6 @@ const {
NumberParseInt,
ObjectDefineProperty,
ObjectSetPrototypeOf,
RegExp,
RegExpPrototypeExec,
Symbol,
SymbolAsyncDispose,
SymbolDispose,
@ -145,8 +143,6 @@ const { kTimeout } = require('internal/timers');
const DEFAULT_IPV4_ADDR = '0.0.0.0';
const DEFAULT_IPV6_ADDR = '::';
const HOST_REGEXP = new RegExp('^[a-zA-Z0-9-:%.]+$');
const noop = () => {};
const kPerfHooksNetConnectContext = Symbol('kPerfHooksNetConnectContext');
@ -2024,10 +2020,6 @@ Server.prototype.listen = function(...args) {
toNumber(args.length > 2 && args[2]); // (port, host, backlog)
options = options._handle || options.handle || options;
if (typeof options.host === 'string' && RegExpPrototypeExec(HOST_REGEXP, options.host) === null) {
throw new ERR_INVALID_ARG_VALUE('host', options.host);
}
const flags = getFlags(options.ipv6Only);
// Refresh the id to make the previous call invalid
this._listeningId++;

12
test/parallel/test-net-server-listen-options.js
View File

@ -15,10 +15,6 @@ function close() { this.close(); }
// Test listen({port})
net.createServer().listen({ port: 0 })
.on('listening', common.mustCall(close));
// Test listen(host, port}) on ipv4
net.createServer().listen({ host: '127.0.0.1', port: '3000' }).on('listening', common.mustCall(close));
// Test listen(host, port}) on ipv6
net.createServer().listen({ host: '::', port: '3001' }).on('listening', common.mustCall(close));
}
// Test listen(port, cb) and listen({ port }, cb) combinations
@ -70,13 +66,6 @@ const listenOnPort = [
name: 'TypeError',
message: /^The argument 'options' must have the property "port" or "path"\. Received .+$/,
});
} else if (typeof options.host === 'string' && !options.host.match(/^[a-zA-Z0-9-:%.]+$/)) {
assert.throws(fn,
{
code: 'ERR_INVALID_ARG_VALUE',
name: 'TypeError',
message: /^The argument 'host' is invalid\. Received .+$/,
});
} else {
assert.throws(fn,
{
@ -102,5 +91,4 @@ const listenOnPort = [
shouldFailToListen({ host: 'localhost:3000' });
shouldFailToListen({ host: { port: 3000 } });
shouldFailToListen({ exclusive: true });
shouldFailToListen({ host: '[::]', port: 3000 });
}