From 4a7b8eae84e7283f8cc50be43562a27f3b74a3a5 Mon Sep 17 00:00:00 2001 From: Jacob Date: Wed, 24 Apr 2019 15:09:27 -0500 Subject: [PATCH] doc: correct entry for electron v4.0.4 `abi_version_registry.json` incorrectly specified that electron v4.0.4 used `NODE_MODULE_VERSION` 64, but in fact it uses 69. See: * https://github.com/electron/electron/pull/16687 * https://github.com/electron/electron/releases/tag/v4.0.4 * https://github.com/lgeiger/node-abi/commit/9e4c1a63e63f8994cc2f5e3efee43785c9eb1c8f PR-URL: https://github.com/nodejs/node/pull/27394 Reviewed-By: Myles Borins Reviewed-By: James M Snell Reviewed-By: Anna Henningsen Reviewed-By: Michael Dawson --- doc/abi_version_registry.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/abi_version_registry.json b/doc/abi_version_registry.json index 6bfb5831dd8..4a0ee7b4a1f 100644 --- a/doc/abi_version_registry.json +++ b/doc/abi_version_registry.json @@ -4,14 +4,14 @@ { "modules": 72, "runtime": "node", "variant": "v8_7.4", "versions": "12.0.0-pre" }, { "modules": 71, "runtime": "node", "variant": "v8_7.3", "versions": "12.0.0-pre" }, { "modules": 70, "runtime": "electron", "variant": "electron", "versions": "5" }, - { "modules": 69, "runtime": "electron", "variant": "electron", "versions": "^4.0.5" }, + { "modules": 69, "runtime": "electron", "variant": "electron", "versions": "^4.0.4" }, { "modules": 68, "runtime": "node", "variant": "v8_7.1", "versions": "12.0.0-pre" }, { "modules": 67, "runtime": "node", "variant": "node", "versions": "11" }, { "modules": 66, "runtime": "node", "variant": "v8_6.9", "versions": "11.0.0-pre" }, { "modules": 65, "runtime": "node", "variant": "v8_6.8", "versions": "11.0.0-pre" }, { "modules": 65, "runtime": "node", "variant": "debian-openssl_1.1.1", "versions": "10" }, { "modules": 64, "runtime": "node", "variant": "node", "versions": "10" }, - { "modules": 64, "runtime": "electron", "variant": "electron", "versions": ">=3 <4.0.5" }, + { "modules": 64, "runtime": "electron", "variant": "electron", "versions": ">=3 <4.0.4" }, { "modules": 63, "runtime": "node", "variant": "v8_6.6", "versions": "10.0.0-pre" }, { "modules": 62, "runtime": "node", "variant": "v8_6.5", "versions": "10.0.0-pre" }, { "modules": 61, "runtime": "node", "variant": "v8_6.4", "versions": "10.0.0-pre" },