mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
doc,test: clarify that Http2Stream is destroyed after data is read
Correct docs to clarify that behaviour, and fix a race condition in test-http2-large-write-destroy.js. Fixes: https://github.com/nodejs/node/issues/27863 PR-URL: https://github.com/nodejs/node/pull/27891 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
parent
3b50bded08
commit
42d80113bb
@ -907,8 +907,9 @@ the value is `undefined`, the stream is not yet ready for use.
|
||||
|
||||
All [`Http2Stream`][] instances are destroyed either when:
|
||||
|
||||
* An `RST_STREAM` frame for the stream is received by the connected peer.
|
||||
* The `http2stream.close()` method is called.
|
||||
* An `RST_STREAM` frame for the stream is received by the connected peer,
|
||||
and pending data has been read.
|
||||
* The `http2stream.close()` method is called, and pending data has been read.
|
||||
* The `http2stream.destroy()` or `http2session.destroy()` methods are called.
|
||||
|
||||
When an `Http2Stream` instance is destroyed, an attempt will be made to send an
|
||||
|
@ -32,6 +32,7 @@ server.listen(0, common.mustCall(() => {
|
||||
|
||||
const req = client.request({ ':path': '/' });
|
||||
req.end();
|
||||
req.resume(); // Otherwise close won't be emitted if there's pending data.
|
||||
|
||||
req.on('close', common.mustCall(() => {
|
||||
client.close();
|
||||
|
Loading…
Reference in New Issue
Block a user