Nodejs/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-11-21 10:59:27 +00:00
Code Issues Actions 25 Packages Projects Releases Wiki Activity

test: pummel test fixes

Browse Source 
This fixes some variable redeclarations in pummel tests and, in the
process, gets `test-stream-pipe-multi.js` to run again. It had been
failing to run.

PR-URL: https://github.com/nodejs/node/pull/4998
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Rich Trott 2016-01-30 22:58:19 -08:00 committed by James M Snell
parent 4736eeca53
commit 39682b4c2c
3 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/pummel/test-crypto-dh.js
View File

@ -30,7 +30,7 @@ var hashes = {
modp18 : 'a870b491bbbec9b131ae9878d07449d32e54f160'
};
for (var name in hashes) {
for (const name in hashes) {
var group = crypto.getDiffieHellman(name);
var private_key = group.getPrime('hex');
var hash1 = hashes[name];
@ -40,7 +40,7 @@ for (var name in hashes) {
assert.equal(group.getGenerator('hex'), '02');
}
for (var name in hashes) {
for (const name in hashes) {
// modp1 is 768 bits, FIPS requires >= 1024
if (name == 'modp1' && common.hasFipsCrypto)
continue;

5
test/pummel/test-exec.js
View File

@ -3,13 +3,14 @@ var common = require('../common');
var assert = require('assert');
var exec = require('child_process').exec;
var SLEEP3_COMMAND;
if (!common.isWindows) {
// Unix.
var SLEEP3_COMMAND = 'sleep 3';
SLEEP3_COMMAND = 'sleep 3';
} else {
// Windows: `choice` is a command built into cmd.exe. Use another cmd process
// to create a process tree, so we can catch bugs related to it.
var SLEEP3_COMMAND = 'cmd /c choice /t 3 /c X /d X';
SLEEP3_COMMAND = 'cmd /c choice /t 3 /c X /d X';
}

6
test/pummel/test-stream-pipe-multi.js
View File

@ -49,11 +49,11 @@ process.on('exit', function() {
assert.equal(cnt, rclosed, 'readable streams closed');
});
for (var i = 0; i < chunkSize; i++) {
chunkSize[i] = i % 256;
for (let i = 0; i < chunkSize; i++) {
data[i] = i;
}
for (var i = 0; i < cnt; i++) {
for (let i = 0; i < cnt; i++) {
var r = new FakeStream();
r.on('close', function() {
console.error(this.ID, 'read close');