Nodejs/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-11-21 10:59:27 +00:00
Code Issues Actions 25 Packages Projects Releases Wiki Activity

test: change test to not be sensitive to buffer send size

Browse Source 
Change the test to not be sensitive to the buffer size causing
TCP resets to be received by the client causing the test to fail.
The test now reads the entire expected buffer and then checks for
the expected event to fire.

PR-URL: https://github.com/nodejs/node/pull/31499
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Rusty Conover 2020-02-25 23:12:51 -05:00 committed by Rich Trott
parent 2b16c13f79
commit 35f491b2e8
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
test/parallel/test-tls-close-event-after-write.js
View File

@ -12,23 +12,22 @@ const tls = require('tls');
const fixtures = require('../common/fixtures');
let cconn = null;
let sconn = null;
let read_len = 0;
const buffer_size = 1024 * 1024;
function test() {
if (cconn && sconn) {
cconn.resume();
sconn.resume();
sconn.end(Buffer.alloc(1024 * 1024));
cconn.end();
sconn.end(Buffer.alloc(buffer_size));
}
}
const server = tls.createServer({
key: fixtures.readKey('agent1-key.pem'),
cert: fixtures.readKey('agent1-cert.pem')
}, function(c) {
c.on('close', function() {
server.close();
});
}, (c) => {
c.on('close', common.mustCall(() => server.close()));
sconn = c;
test();
}).listen(0, common.mustCall(function() {
@ -36,6 +35,12 @@ const server = tls.createServer({
rejectUnauthorized: false
}, common.mustCall(function() {
cconn = this;
cconn.on('data', (d) => {
read_len += d.length;
if (read_len === buffer_size) {
cconn.end();
}
});
test();
}));
}));