Nodejs/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-11-21 10:59:27 +00:00
Code Issues Actions 25 Packages Projects Releases Wiki Activity

test: add Debugger.setInstrumentationBreakpoint known issue

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/31137
Refs: https://github.com/nodejs/node/issues/31138
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Konstantin Ulitin 2024-05-12 22:33:07 +02:00 committed by GitHub
parent 91d30f35c4
commit 291c1211f2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 58 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/common/index.js
View File

@ -603,7 +603,8 @@ function printSkipMessage(msg) {
function skip(msg) {
printSkipMessage(msg);
process.exit(0);
// In known_issues test, skipping should produce a non-zero exit code.
process.exit(require.main?.filename.startsWith(path.resolve(__dirname, '../known_issues/')) ? 1 : 0);
}
// Returns true if the exit code "exitCode" and/or signal name "signal"

1
test/fixtures/inspector-instrumentation-breakpoint/dep.js vendored Normal file
View File

@ -0,0 +1 @@
console.log('dep loaded');

1
test/fixtures/inspector-instrumentation-breakpoint/main.js vendored Normal file
View File

@ -0,0 +1 @@
require('./dep');

54
test/known_issues/test-inspector-instrumentation-breakpoint.js Normal file
View File

@ -0,0 +1,54 @@
// This test validates inspector's Debugger.setInstrumentationBreakpoint method.
// Refs: https://github.com/nodejs/node/issues/31138
'use strict';
const common = require('../common');
common.skipIfInspectorDisabled();
const assert = require('assert');
const { resolve: UrlResolve } = require('url');
const fixtures = require('../common/fixtures');
const { NodeInstance } = require('../common/inspector-helper.js');
async function testBreakpointBeforeScriptExecution(session) {
console.log('[test]',
'Verifying debugger stops on start of each script ' +
'(Debugger.setInstrumentationBreakpoint with beforeScriptExecution)');
const commands = [
{ 'method': 'Runtime.enable' },
{ 'method': 'Debugger.enable' },
{ 'method': 'Debugger.setInstrumentationBreakpoint',
'params': { 'instrumentation': 'beforeScriptExecution' } },
{ 'method': 'Runtime.runIfWaitingForDebugger' },
];
await session.send(commands);
// Break on start
await session.waitForBreakOnLine(
0, UrlResolve(session.scriptURL().toString(), 'main.js'));
await session.send([{ 'method': 'Debugger.resume' }]);
// Script loaded
await session.waitForBreakOnLine(
0, UrlResolve(session.scriptURL().toString(), 'main.js'));
await session.send([{ 'method': 'Debugger.resume' }]);
// Script loaded
await session.waitForBreakOnLine(
0, UrlResolve(session.scriptURL().toString(), 'dep.js'));
await session.send([{ 'method': 'Debugger.resume' }]);
}
async function runTest() {
const main = fixtures.path('inspector-instrumentation-breakpoint', 'main.js');
const child = new NodeInstance(['--inspect-brk=0'], '', main);
const session = await child.connectInspectorSession();
await testBreakpointBeforeScriptExecution(session);
await session.runToCompletion();
assert.strictEqual((await child.expectShutdown()).exitCode, 0);
}
runTest();