Nodejs/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-11-21 10:59:27 +00:00
Code Issues Actions 25 Packages Projects Releases Wiki Activity

doc: remove unavailable youtube link in pull requests

Browse Source 
This video(https://www.youtube.com/watch?v=HW0RPaJqm4g) isn't
available anymore. And I couldn't find a proper github code
review tutorial clip yet.

PR-URL: https://github.com/nodejs/node/pull/52982
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
This commit is contained in:
Deokjin Kim 2024-05-17 00:44:13 +09:00 committed by GitHub
parent dad539f0c3
commit 2693f0916f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
doc/contributing/pull-requests.md
View File

@ -548,8 +548,7 @@ A pull request is approved either by saying LGTM, which stands for
"Looks Good To Me", or by using GitHub's Approve button. "Looks Good To Me", or by using GitHub's Approve button.
GitHub's pull request review feature can be used during the process. GitHub's pull request review feature can be used during the process.
For more information, check out For more information, check out
[the video tutorial](https://www.youtube.com/watch?v=HW0RPaJqm4g) [the official documentation](https://help.github.com/articles/reviewing-changes-in-pull-requests/).
or [the official documentation](https://help.github.com/articles/reviewing-changes-in-pull-requests/).
After you push new changes to your branch, you need to get After you push new changes to your branch, you need to get
approval for these new changes again, even if GitHub shows "Approved" approval for these new changes again, even if GitHub shows "Approved"