Nodejs/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-11-21 10:59:27 +00:00
Code Issues Actions 25 Packages Projects Releases Wiki Activity

test_runner: require --enable-source-maps for sourcemap coverage

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/55359
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
This commit is contained in:
Aviv Keller 2024-10-14 09:19:17 -04:00 committed by GitHub
parent 48b852a7f5
commit 10addb0a20
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 33 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/internal/test_runner/coverage.js
View File

@ -57,12 +57,19 @@ class CoverageLine {
}
class TestCoverage {
constructor(coverageDirectory, originalCoverageDirectory, workingDirectory, excludeGlobs, includeGlobs, thresholds) {
constructor(coverageDirectory,
originalCoverageDirectory,
workingDirectory,
excludeGlobs,
includeGlobs,
sourceMaps,
thresholds) {
this.coverageDirectory = coverageDirectory;
this.originalCoverageDirectory = originalCoverageDirectory;
this.workingDirectory = workingDirectory;
this.excludeGlobs = excludeGlobs;
this.includeGlobs = includeGlobs;
this.sourceMaps = sourceMaps;
this.thresholds = thresholds;
}
@ -341,7 +348,7 @@ class TestCoverage {
mapCoverageWithSourceMap(coverage) {
const { result } = coverage;
const sourceMapCache = coverage['source-map-cache'];
if (!sourceMapCache) {
if (!this.sourceMaps || !sourceMapCache) {
return result;
}
const newResult = new SafeMap();
@ -514,6 +521,7 @@ function setupCoverage(options) {
options.cwd,
options.coverageExcludeGlobs,
options.coverageIncludeGlobs,
options.sourceMaps,
{
__proto__: null,
line: options.lineCoverage,

23
test/parallel/test-runner-coverage-source-map.js
View File

@ -19,6 +19,7 @@ function generateReport(report) {
}
const flags = [
'--enable-source-maps',
'--test', '--experimental-test-coverage', '--test-reporter', 'tap',
];
@ -40,6 +41,28 @@ describe('Coverage with source maps', async () => {
const spawned = await common.spawnPromisified(process.execPath, flags, {
cwd: fixtures.path('test-runner', 'coverage')
});
t.assert.strictEqual(spawned.stderr, '');
t.assert.ok(spawned.stdout.includes(report));
t.assert.strictEqual(spawned.code, 1);
});
await it('should only work with --enable-source-maps', async (t) => {
const report = generateReport([
'# --------------------------------------------------------------',
'# file | line % | branch % | funcs % | uncovered lines',
'# --------------------------------------------------------------',
'# a.test.mjs | 100.00 | 100.00 | 100.00 | ',
'# index.test.js | 71.43 | 66.67 | 100.00 | 6-7',
'# stdin.test.js | 100.00 | 100.00 | 100.00 | ',
'# --------------------------------------------------------------',
'# all files | 85.71 | 87.50 | 100.00 | ',
'# --------------------------------------------------------------',
]);
const spawned = await common.spawnPromisified(process.execPath, flags.slice(1), {
cwd: fixtures.path('test-runner', 'coverage')
});
t.assert.strictEqual(spawned.stderr, '');
t.assert.ok(spawned.stdout.includes(report));
t.assert.strictEqual(spawned.code, 1);