From 03dcd7077a179d11858d0f3db9426d3d732fa35e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Juan=20Jos=C3=A9?= <soyjuanarbol@gmail.com>
Date: Tue, 5 Nov 2024 15:44:24 -0500
Subject: [PATCH] src: nuke deprecated and un-used enum members in
 `OptionEnvvarSettings`
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Delete deprecated an never used enum options `kAllowedInEnvironment`
and `kDisallowedInEnvironment` in `OptionEnvvarSettings`

Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/53079
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
---
 src/node.h                           | 4 ----
 typings/internalBinding/options.d.ts | 4 ++--
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/node.h b/src/node.h
index 32d346fc4f8..643f964115b 100644
--- a/src/node.h
+++ b/src/node.h
@@ -374,10 +374,6 @@ enum OptionEnvvarSettings {
   // Disallow the options to be set via the environment variable, like
   // `NODE_OPTIONS`.
   kDisallowedInEnvvar = 1,
-  // Deprecated, use kAllowedInEnvvar instead.
-  kAllowedInEnvironment = kAllowedInEnvvar,
-  // Deprecated, use kDisallowedInEnvvar instead.
-  kDisallowedInEnvironment = kDisallowedInEnvvar,
 };
 
 // Process the arguments and set up the per-process options.
diff --git a/typings/internalBinding/options.d.ts b/typings/internalBinding/options.d.ts
index 8248997d463..e7532f0a3dc 100644
--- a/typings/internalBinding/options.d.ts
+++ b/typings/internalBinding/options.d.ts
@@ -17,8 +17,8 @@ export interface OptionsBinding {
     aliases: Map<string, string[]>;
   };
   envSettings: {
-    kAllowedInEnvironment: 0;
-    kDisallowedInEnvironment: 1;
+    kAllowedInEnvvar: 0;
+    kDisallowedInEnvvar: 1;
   };
   noGlobalSearchPaths: boolean;
   shouldNotRegisterESMLoader: boolean;