Nodejs/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-11-21 10:59:27 +00:00
Code Issues Actions 25 Packages Projects Releases Wiki Activity
main
node/.github/PULL_REQUEST_TEMPLATE.md

42 lines
1.7 KiB
Markdown
Raw Permalink Normal View History

doc: improve github templates by using comments Use HTML comments to reduce potential noise in github templates. Also, improve flow of the pull request, making it easier to read. PR-URL: https://github.com/nodejs/node/pull/5710 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
2016-03-15 05:06:09 +00:00
<!--
doc: remove the . in the end to reduce confusing PR-URL: https://github.com/nodejs/node/pull/48719 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
2023-07-17 09:54:51 +00:00
Before submitting a pull request, please read:
github: add issue and pull request templates Fix: #5246 PR-URL: https://github.com/nodejs/node/pull/5291 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Steven R. Loomis <srloomis@us.ibm.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
2016-02-17 20:48:00 +00:00
doc: remove the . in the end to reduce confusing PR-URL: https://github.com/nodejs/node/pull/48719 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
2023-07-17 09:54:51 +00:00
- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines
github: add issue and pull request templates Fix: #5246 PR-URL: https://github.com/nodejs/node/pull/5291 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Steven R. Loomis <srloomis@us.ibm.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
2016-02-17 20:48:00 +00:00
doc: simplify pull request template Replace checklist with a list. Clarify when things like tests and benchmarks are needed. PR-URL: https://github.com/nodejs/node/pull/36739 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yash Ladha <yash@yashladha.in>
2021-01-02 14:34:14 +00:00
For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.
github: add issue and pull request templates Fix: #5246 PR-URL: https://github.com/nodejs/node/pull/5291 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Steven R. Loomis <srloomis@us.ibm.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
2016-02-17 20:48:00 +00:00
doc: add notable-change label mention to PR template PR-URL: https://github.com/nodejs/node/pull/49188 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
2023-08-17 21:09:36 +00:00
If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.
doc: add dco to github pr template Our project relies on the Developer Certificate of Origin as a passive alternative to a Contributor License Agreement. The PR template seems like a great place to surface the text to help new contributors be aware of the DCO and it's implications. PR-URL: https://github.com/nodejs/node/pull/24023 Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
2018-11-01 19:15:56 +00:00
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
-->
Reference in New Issue Copy Permalink