Deno/rusty_v8
1
0
Fork 0
mirror of https://github.com/denoland/rusty_v8.git synced 2024-11-22 04:40:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fallback to curl if download_file.py fails (#373)

Browse Source
This commit is contained in:
George Hahn 2020-05-31 13:36:56 -05:00 committed by GitHub
parent a9ea69b5d5
commit d87341a7ce
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 34 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

47
build.rs
View File

@ -187,6 +187,39 @@ fn static_lib_url() -> (String, String) {
}
}
fn download_file(url: String, filename: PathBuf) {
// Try downloading with python first. Python is a V8 build dependency,
// so this saves us from adding a Rust HTTP client dependency.
println!("Downloading {}", url);
let status = Command::new("python")
.arg("./tools/download_file.py")
.arg("--url")
.arg(&url)
.arg("--filename")
.arg(&filename)
.status();
// Python is only a required dependency for `V8_FROM_SOURCE` builds.
// If python is not available, try falling back to curl.
let status = match status {
Ok(status) if status.success() => status,
_ => {
println!("Python downloader failed, trying with curl.");
Command::new("curl")
.arg("-L")
.arg("-s")
.arg("-o")
.arg(&filename)
.arg(&url)
.status()
.unwrap()
}
};
assert!(status.success());
assert!(filename.exists());
}
fn download_static_lib_binaries() {
let (url, static_lib_name) = static_lib_url();
println!("static lib URL: {}", url);
@ -216,19 +249,7 @@ fn download_static_lib_binaries() {
println!("static lib already exists {}", filename.display());
println!("To re-download this file, it must be manually deleted.");
} else {
// Using python to do the HTTP download because it's already a dependency
// and so we don't have to add a Rust HTTP client dependency.
println!("Downloading {}", url);
let status = Command::new("python")
.arg("./tools/download_file.py")
.arg("--url")
.arg(url)
.arg("--filename")
.arg(&filename)
.status()
.unwrap();
assert!(status.success());
assert!(filename.exists());
download_file(url, filename);
}
}