Deno/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-21 20:38:55 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

fix(ext/webstorage): make getOwnPropertyDescriptor with symbol return undefined (#13348)

Browse Source 
Closes #13347
This commit is contained in:
Leo Kettmeir 2024-10-07 07:59:27 -07:00 committed by GitHub
parent 39a2034967
commit 9a92603a14
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ext/webstorage/01_webstorage.js
View File

@ -143,6 +143,9 @@ function createStorage(persistent) {
if (ReflectHas(target, key)) { if (ReflectHas(target, key)) {
return undefined; return undefined;
} }
if (typeof key === "symbol") {
return undefined;
}
const value = target.getItem(key); const value = target.getItem(key);
if (value === null) { if (value === null) {
return undefined; return undefined;

5
tests/unit/webstorage_test.ts
View File

@ -50,3 +50,8 @@ Deno.test(function webstorageProxy() {
assertEquals(localStorage[symbol as any], "bar"); assertEquals(localStorage[symbol as any], "bar");
assertEquals(symbol in localStorage, true); assertEquals(symbol in localStorage, true);
}); });
Deno.test(function webstorageGetOwnPropertyDescriptorSymbol() {
localStorage.clear();
Object.getOwnPropertyDescriptor(localStorage, Symbol("foo"));
});