Deno/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-22 04:51:22 +00:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

tests: re-enable disabled Response.formData test (#11453)

Browse Source
This commit is contained in:
Luca Casonato 2021-07-20 00:11:50 +02:00 committed by GitHub
parent 7d69f06db8
commit 55632266e9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 22 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cli/tests/unit/fetch_test.ts
View File

@ -275,7 +275,7 @@ unitTest(
await response.formData();
},
TypeError,
"Invalid form data",
"Body can not be decoded as form data",
);
},
);

11
cli/tests/unit/response_test.ts
View File

@ -43,18 +43,17 @@ unitTest(async function responseBlob() {
assertEquals(await blob.arrayBuffer(), new Uint8Array([1, 2, 3]).buffer);
});
// TODO(lucacasonato): re-enable test once #10002 is fixed.
unitTest({ ignore: true }, async function responseFormData() {
unitTest(async function responseFormData() {
const input = new FormData();
input.append("hello", "world");
const response = new Response(input, {
headers: { "content-type": "application/x-www-form-urlencoded" },
});
const response = new Response(input);
const contentType = response.headers.get("content-type")!;
assert(contentType.startsWith("multipart/form-data"));
const formDataPromise = response.formData();
assert(formDataPromise instanceof Promise);
const formData = await formDataPromise;
assert(formData instanceof FormData);
assertEquals(formData, input);
assertEquals([...formData], [...input]);
});
unitTest(function customInspectFunction(): void {

34
extensions/fetch/22_body.js
View File

@ -286,27 +286,25 @@
});
case "FormData": {
if (mimeType !== null) {
if (mimeType !== null) {
const essence = mimesniff.essence(mimeType);
if (essence === "multipart/form-data") {
const boundary = mimeType.parameters.get("boundary");
if (boundary === null) {
throw new TypeError(
"Missing boundary parameter in mime type of multipart formdata.",
);
}
return parseFormData(bytes, boundary);
} else if (essence === "application/x-www-form-urlencoded") {
const entries = parseUrlEncoded(bytes);
return formDataFromEntries(
ArrayPrototypeMap(
entries,
(x) => ({ name: x[0], value: x[1] }),
),
const essence = mimesniff.essence(mimeType);
if (essence === "multipart/form-data") {
const boundary = mimeType.parameters.get("boundary");
if (boundary === null) {
throw new TypeError(
"Missing boundary parameter in mime type of multipart formdata.",
);
}
return parseFormData(bytes, boundary);
} else if (essence === "application/x-www-form-urlencoded") {
const entries = parseUrlEncoded(bytes);
return formDataFromEntries(
ArrayPrototypeMap(
entries,
(x) => ({ name: x[0], value: x[1] }),
),
);
}
throw new TypeError("Invalid form data");
throw new TypeError("Body can not be decoded as form data");
}
throw new TypeError("Missing content type");
}